git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] MyFirstContribution: clarify that "reviewing" is a discussion

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 21, 2026, 16:22 UTC
Message-ID
<xmqqecdjqb10.fsf@gitster.g>
In-Reply-To
<ath8r6RX0u2Uq4x_@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
>>  [[reviewing]]
>>  === Responding to Reviews
>>  
>> -After a few days, you will hopefully receive a reply to your patchset with some
>> -comments. Woohoo! Now you can get back to work.
>> -
>> -It's good manners to reply to each comment in the mailing list discussion
>> -instead of letting the next version of your patch be your only response. Tell
>> -the reviewer whether you plan to make the suggested change, keep the original,
>> -or pursue a different approach.
>
> This is a sentence we lose in the rewrite, but I'd say that it may be
> useful information to retain.

Hmph, "communicate your plan" certainly is half lost. An early section ("now-what") advises to communicate "I'll do it differently, disregard this iteration" to avoid wasting reviewers' time, and the rewritten "reviewing" section somewhat hints to communicate other kind of plans with "your reasoning" in

    Do not start coding, much less send the next version of your patch,
    until you have finished discussing the current round of reviews with
    your reviewers.  This saves time for both you and your reviewers.
    They can respond to your reasoning before you spend time preparing a
    version they might reject, and they will not have to inspect your
    'v2' to check if you addressed their concerns.

but it would be better to be more explicit how "your reasoning" should be presented, I guess. How about inserting "so that both sides know what to expect in the next round" to clarify what "finish discussing" entails?

    Do not start coding, let alone send the next version of your
    patch, until you have finished discussing the current one so
    both sides know what to expect.  This saves time for everyone.
    Reviewers can respond to your explanation before you spend time
    preparing a patch they might reject, and they will not have to
    inspect 'v2' only to find their concerns unaddressed.
Thanks.
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 9 of 15 in “MyFirstContribution: move preparation of v2 after review discussion”
  1. MyFirstContribution: move preparation of v2 after review discussionJunio C Hamano, Oct 19, 2026
  2. Patrick SteinhardtOct 20, 2026
  3. Junio C HamanoOct 20, 2026
  4. 0/2 MyFirstContribution: discuss then rerollJunio C Hamano, Oct 20, 2026
  5. 1/2 MyFirstContribution: move "how to send v2" after discussing reviewsJunio C Hamano, Oct 20, 2026
  6. Patrick SteinhardtOct 21, 2026
  7. 2/2 MyFirstContribution: clarify that "reviewing" is a discussionJunio C Hamano, Oct 20, 2026
  8. Patrick SteinhardtOct 21, 2026
  9. Junio C HamanoOct 21, 2026
  10. Patrick SteinhardtOct 22, 2026
  11. 0/2 MyFirstContribution: discuss then rerollJunio C Hamano, Oct 22, 2026
  12. 1/2 MyFirstContribution: move "how to send v2" after discussing reviewsJunio C Hamano, Oct 22, 2026
  13. 2/2 MyFirstContribution: clarify that "reviewing" is a discussionJunio C Hamano, Oct 22, 2026
  14. Patrick SteinhardtOct 23, 2026
  15. Junio C HamanoOct 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.