git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] MyFirstContribution: clarify that "reviewing" is a discussion

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 21, 2026, 08:49 UTC
Message-ID
<ath8r6RX0u2Uq4x_@pks.im>
In-Reply-To
<20261020232242.2217109-3-gitster@pobox.com>
On Tue, Oct 20, 2026 at 04:22:42PM -0700, Junio C Hamano wrote:
Show 41 quoted lines
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 682c797e3c..3fd6587e5a 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1314,56 +1314,42 @@ previous one" patches over 2 days), reviewers would strongly prefer if a
>  single polished version came 2 days later instead, and that version with
>  fewer mistakes were the only one they would need to review.
>  
> -This consideration applies not only when going from the initial patch to v2,
> -but also to later iterations of the same series. There is no fixed rule for how
> -long to wait before sending a new version. A useful default is to send at most
> -one new version of the same patch series per day. This gives multiple reviewers
> -time to comment, gives reviewers across time zones a fair chance to
> -participate, lets you batch feedback together, and gives you time to think
> -through the comments you received. Knowing that you should not immediately send
> -another version also encourages you to review the patches more carefully before
> -sending them, catch small mistakes such as typos and off-by-one errors
> -yourself, and let reviewers spend more of their attention on design,
> -algorithms, and other substantial issues.
> -
> -The right timing depends on the topic and the feedback. Larger series usually
> -need more review time. If the only comments so far are minor, such as typo
> -fixes, it often makes sense to wait a little longer in case deeper reviews are
> -still coming. If the comments call for substantial rework, do not rush out an
> -updated version before you have reviewed the larger changes carefully. Instead,
> -reply to the review that prompted the rewrite, say that you are preparing a
> -substantial rework, and mention which parts of the current series will become
> -obsolete so reviewers can avoid spending time on them until the updated series
> -is ready.
> -
>  
>  [[reviewing]]
>  === Responding to Reviews
>  
> -After a few days, you will hopefully receive a reply to your patchset with some
> -comments. Woohoo! Now you can get back to work.
> -
> -It's good manners to reply to each comment in the mailing list discussion
> -instead of letting the next version of your patch be your only response. Tell
> -the reviewer whether you plan to make the suggested change, keep the original,
> -or pursue a different approach.

This is a sentence we lose in the rewrite, but I'd say that it may be useful information to retain.

Other than that I don't have any significant things to add, thanks!
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 15 in “MyFirstContribution: move preparation of v2 after review discussion”
  1. MyFirstContribution: move preparation of v2 after review discussionJunio C Hamano, Oct 19, 2026
  2. Patrick SteinhardtOct 20, 2026
  3. Junio C HamanoOct 20, 2026
  4. 0/2 MyFirstContribution: discuss then rerollJunio C Hamano, Oct 20, 2026
  5. 1/2 MyFirstContribution: move "how to send v2" after discussing reviewsJunio C Hamano, Oct 20, 2026
  6. Patrick SteinhardtOct 21, 2026
  7. 2/2 MyFirstContribution: clarify that "reviewing" is a discussionJunio C Hamano, Oct 20, 2026
  8. Patrick SteinhardtOct 21, 2026
  9. Junio C HamanoOct 21, 2026
  10. Patrick SteinhardtOct 22, 2026
  11. 0/2 MyFirstContribution: discuss then rerollJunio C Hamano, Oct 22, 2026
  12. 1/2 MyFirstContribution: move "how to send v2" after discussing reviewsJunio C Hamano, Oct 22, 2026
  13. 2/2 MyFirstContribution: clarify that "reviewing" is a discussionJunio C Hamano, Oct 22, 2026
  14. Patrick SteinhardtOct 23, 2026
  15. Junio C HamanoOct 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.