git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] MyFirstContribution: move "how to send v2" after discussing reviews

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 21, 2026, 08:49 UTC
Message-ID
<ath8s3kEQoQwK_lo@pks.im>
In-Reply-To
<20261020232242.2217109-2-gitster@pobox.com>
On Tue, Oct 20, 2026 at 04:22:41PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> The MyFirstContribution document tells readers how to send v1, how
> to send v2, and then how to respond to reviews, in that order.
> 
> It is unclear how much blame can be placed on this text, but senior
> community members find themselves more and more frequently having to
> tell new contributors not to send updated iterations of their patches
> before having any review discussion on the current iteration.
> 
> As a small first step to rectify the situation, move the description
> of how to send v2 so that it appears after we have told readers to
> expect and respond to reviews on their first iteration.  This step
> contains no text changes.  Only the ordering changes, which are
> friendly to 'git diff --color-moved', are included here.
Yup. And that command shows that it's a trivial move indeed.
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 15 in “MyFirstContribution: move preparation of v2 after review discussion”
  1. MyFirstContribution: move preparation of v2 after review discussionJunio C Hamano, Oct 19, 2026
  2. Patrick SteinhardtOct 20, 2026
  3. Junio C HamanoOct 20, 2026
  4. 0/2 MyFirstContribution: discuss then rerollJunio C Hamano, Oct 20, 2026
  5. 1/2 MyFirstContribution: move "how to send v2" after discussing reviewsJunio C Hamano, Oct 20, 2026
  6. Patrick SteinhardtOct 21, 2026
  7. 2/2 MyFirstContribution: clarify that "reviewing" is a discussionJunio C Hamano, Oct 20, 2026
  8. Patrick SteinhardtOct 21, 2026
  9. Junio C HamanoOct 21, 2026
  10. Patrick SteinhardtOct 22, 2026
  11. 0/2 MyFirstContribution: discuss then rerollJunio C Hamano, Oct 22, 2026
  12. 1/2 MyFirstContribution: move "how to send v2" after discussing reviewsJunio C Hamano, Oct 22, 2026
  13. 2/2 MyFirstContribution: clarify that "reviewing" is a discussionJunio C Hamano, Oct 22, 2026
  14. Patrick SteinhardtOct 23, 2026
  15. Junio C HamanoOct 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.