Re: [PATCH] MyFirstContribution: move preparation of v2 after review discussion
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2026, 16:32 UTC
- Message-ID
- <xmqqbj8oxrh3.fsf@gitster.g>
- In-Reply-To
- <atd7xT6Vj59omtuN@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> Nit: I think this would have been easier to review if you first moved > stuff around without changing the language yet and only then changing it > in a second commit. Like this it's basically impossible to see what was > moved and what needs reviewing.
Yeah, I was thinking exactly that after sending it out. Will do so when I try it again after sleeping on the topic for a few days and seeing other comments that hopefully will come in the meantime.
Thanks.