Re: [PATCH v3] help: make option --help open man pages only for Git commands
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 16, 2016, 19:06 UTC
- Message-ID
- <xmqqd1l8cz3n.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAN0XMOL2WZkh17v-7OtA8AMbzs4NUuj8xPVwJBD-PnK4fBaUFw@mail.gmail.com>
Ralf Thielow <ralf.thielow@gmail.com> writes:
Show 16 quoted lines
> 2016-08-16 19:27 GMT+02:00 Junio C Hamano <gitster@pobox.com>: >> Ralf Thielow <ralf.thielow@gmail.com> writes: >>> + >>> + if (swapped) >>> + return help_unknown_cmd(cmd); >> >> I am guilty of suggesting "swapped"; even if we are going to mark >> this as OPT_HIDDEN, I think we should be able to think of a better >> name. I think the meaning of this boolean is "we know that this is >> not a guide and is meant to be a command.", and I hope we can come >> up with a name that concisely expresses that (e.g. "--not-a-guide", >> "--must-be-a-command"). >> > > I think "--cmd-only" is a good name. With a good name I think it's worth > to make this option visible to the user.
Sure. I'd prefer "cmd" to be spelled out in anything that is end-user facing, though.