Re: [PATCH 1/2] help: introduce option --command-only
- From
Ralf Thielow <ralf.thielow@gmail.com>
- Date
- Aug 23, 2016, 17:41 UTC
- Message-ID
- <CAN0XMOLTc5zzjXwnpDwhs-coP9BVD659CpYEJYp_v4789M2CpQ@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.2.20.1608190954461.4924@virtualbox>
2016-08-19 10:32 GMT+02:00 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
Show 17 quoted lines
> So how about fixing that? I would suggest to do it this way: > > - configure help.format = html (for "man", the current code would always > add $(prefix)/share/man to the MANPATH when testing, not what we want, > and hacking this code *just* for testing is both ugly and unnecessary). > > - configure help.htmlpath to point to a subdirectory that is created and > populated in the same test script. > > - configure help.browser to point to a script that is created in the same > script and whose output we can verify, too. > > The last point actually requires a patch that was recently introduced into > Git for Windows [*1*] (and that did not make it upstream yet) which > reverts that change whereby web--browse was sidestepped. That sidestepping > was well-intentioned but turned out to cause more harm than good. >
So I'll pickup the patch you sent [1] to my series and prepare the test cases the way you described to verify that the 'help' command works.
Thanks!
[1] http://public-inbox.org/git/03ae6a9d47cb95a54960bfdc90c5392f890ff1e3.1471595956.git.johannes.schindelin@gmx.de/