Re: [PATCH v3] help: make option --help open man pages only for Git commands

From: Ralf Thielow <ralf.thielow@gmail.com>
Date: Aug 16, 2016, 17:57 UTC
Message-ID: <CAN0XMOL2WZkh17v-7OtA8AMbzs4NUuj8xPVwJBD-PnK4fBaUFw@mail.gmail.com>
In-Reply-To: <xmqq60r0ei9k.fsf@gitster.mtv.corp.google.com>

2016-08-16 19:27 GMT+02:00 Junio C Hamano <gitster@pobox.com>:

Show 12 quoted lines

> Ralf Thielow <ralf.thielow@gmail.com> writes:
>> +
>> +     if (swapped)
>> +             return help_unknown_cmd(cmd);
>
> I am guilty of suggesting "swapped"; even if we are going to mark
> this as OPT_HIDDEN, I think we should be able to think of a better
> name.  I think the meaning of this boolean is "we know that this is
> not a guide and is meant to be a command.", and I hope we can come
> up with a name that concisely expresses that (e.g. "--not-a-guide",
> "--must-be-a-command").
>

I think "--cmd-only" is a good name. With a good name I think it's worth to make this option visible to the user.