Re: [PATCH v3 1/7] bisect--helper: reimplement `bisect_log` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2021, 18:32 UTC
Message-ID: <xmqqczxr35xs.fsf@gitster.c.googlers.com>
In-Reply-To: <CAN7CjDANLB85GHVVn32w_Y70bzvadtqdq2uRyc81j7nz+W05jA@mail.gmail.com>

"Miriam R." <mirucam@gmail.com> writes:

Show 7 quoted lines

>> Although I compiled and did small test on the above code snippet, don't
>> trust it blindly and perform your own test and judge whether this is the
>> best way to implement this shortcoming.
> Ok, thank you.
> I am not the original author of this subcommand reimplementation
> and I don't know if there is a reason for the difference with the
> error message. Maybe we can wait for some other reviewers opinion.

Sorry I missed this thread.

My understanding is that this topic is an attempt to "reimplement" what is there in the scripted version, so any deviation of behaviour obserbable from outside, which is *not* justified, should by definition be treated as a bug.

If the original author did not explain why the behaviour difference exists and defend why the new behaviour in the reimplementation is better, and if you do not think of a good reason why the behaviour should be different and the new behaviour is better, then let's treat it in a bug and fix it.

Thanks.