Re: [PATCH v3 1/7] bisect--helper: reimplement `bisect_log` shell function in C
- From
Miriam R. <mirucam@gmail.com>
- Date
- Jan 27, 2021, 14:10 UTC
- Message-ID
- <CAN7CjDCbbKLKVjCP5kWzAJXFBJs5G_MRST0rdTgvH0yTusRqeg@mail.gmail.com>
- In-Reply-To
- <xmqqczxr35xs.fsf@gitster.c.googlers.com>
Hi,
El mar, 26 ene 2021 a las 19:32, Junio C Hamano (<gitster@pobox.com>) escribió:
Show 24 quoted lines
> > "Miriam R." <mirucam@gmail.com> writes: > > >> Although I compiled and did small test on the above code snippet, don't > >> trust it blindly and perform your own test and judge whether this is the > >> best way to implement this shortcoming. > > Ok, thank you. > > I am not the original author of this subcommand reimplementation > > and I don't know if there is a reason for the difference with the > > error message. Maybe we can wait for some other reviewers opinion. > > Sorry I missed this thread. > > My understanding is that this topic is an attempt to "reimplement" > what is there in the scripted version, so any deviation of behaviour > obserbable from outside, which is *not* justified, should by > definition be treated as a bug. > > If the original author did not explain why the behaviour difference > exists and defend why the new behaviour in the reimplementation is > better, and if you do not think of a good reason why the behaviour > should be different and the new behaviour is better, then let's > treat it in a bug and fix it. >
Ok, I will send another patch series adding this. Thank you. Miriam.
> Thanks.