git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/7] bisect--helper: retire `--bisect-auto-next` subcommand

From
Miriam Rubio <mirucam@gmail.com>
Date
Jan 23, 2021, 15:40 UTC
Message-ID
<20210123154056.48234-6-mirucam@gmail.com>
In-Reply-To
<20210123154056.48234-1-mirucam@gmail.com>
From: Pranit Bauva <pranit.bauva@gmail.com>

The --bisect-auto-next subcommand is no longer used from the git-bisect.sh shell script. Instead the function bisect_auto_next() is directly called from the C implementation.

Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 builtin/bisect--helper.c | 10 ----------
 1 file changed, 10 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 1ce0399ad4..1e53845e69 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -27,7 +27,6 @@ static const char * const git_bisect_helper_usage[] = {
 	N_("git bisect--helper --bisect-start [--term-{new,bad}=<term> --term-{old,good}=<term>]"
 					    " [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<paths>...]"),
 	N_("git bisect--helper --bisect-next"),
-	N_("git bisect--helper --bisect-auto-next"),
 	N_("git bisect--helper --bisect-state (bad|new) [<rev>]"),
 	N_("git bisect--helper --bisect-state (good|old) [<rev>...]"),
 	N_("git bisect--helper --bisect-replay <filename>"),
@@ -998,7 +997,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 		BISECT_START,
 		BISECT_AUTOSTART,
 		BISECT_NEXT,
-		BISECT_AUTO_NEXT,
 		BISECT_STATE,
 		BISECT_LOG,
 		BISECT_REPLAY
@@ -1017,8 +1015,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 			 N_("start the bisect session"), BISECT_START),
 		OPT_CMDMODE(0, "bisect-next", &cmdmode,
 			 N_("find the next bisection commit"), BISECT_NEXT),
-		OPT_CMDMODE(0, "bisect-auto-next", &cmdmode,
-			 N_("verify the next bisection state then checkout the next bisection commit"), BISECT_AUTO_NEXT),
 		OPT_CMDMODE(0, "bisect-state", &cmdmode,
 			 N_("mark the state of ref (or refs)"), BISECT_STATE),
 		OPT_CMDMODE(0, "bisect-log", &cmdmode,
@@ -1071,12 +1067,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 		get_terms(&terms);
 		res = bisect_next(&terms, prefix);
 		break;
-	case BISECT_AUTO_NEXT:
-		if (argc)
-			return error(_("--bisect-auto-next requires 0 arguments"));
-		get_terms(&terms);
-		res = bisect_auto_next(&terms, prefix);
-		break;
 	case BISECT_STATE:
 		set_terms(&terms, "bad", "good");
 		get_terms(&terms);
-- 
2.29.2
Previous: Miriam R.Next: Miriam Rubio
Message 12 of 19 in “Finish converting git bisect to C part 3”
  1. 0/7 Finish converting git bisect to C part 3Miriam Rubio, Jan 23, 2021
  2. 1/7 bisect--helper: reimplement `bisect_log` shell function in CMiriam Rubio, Jan 23, 2021
  3. Rafael SilvaJan 24, 2021
  4. Miriam R.Jan 25, 2021
  5. Junio C HamanoJan 26, 2021
  6. Miriam R.Jan 27, 2021
  7. 3/7 bisect--helper: retire `--bisect-write` subcommandMiriam Rubio, Jan 23, 2021
  8. 2/7 bisect--helper: reimplement `bisect_replay` shell function in CMiriam Rubio, Jan 23, 2021
  9. Junio C HamanoJan 24, 2021
  10. Junio C HamanoJan 24, 2021
  11. Miriam R.Jan 25, 2021
  12. 5/7 bisect--helper: retire `--bisect-auto-next` subcommandMiriam Rubio, Jan 23, 2021
  13. 4/7 bisect--helper: use `res` instead of return in BISECT_RESET case optionMiriam Rubio, Jan 23, 2021
  14. 6/7 bisect--helper: reimplement `bisect_skip` shell function in CMiriam Rubio, Jan 23, 2021
  15. 7/7 bisect--helper: retire `--check-and-set-terms` subcommandMiriam Rubio, Jan 23, 2021
  16. Junio C HamanoJan 26, 2021
  17. Miriam R.Jan 26, 2021
  18. Junio C HamanoJan 26, 2021
  19. Miriam R.Jan 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.