Re: [PATCH v3 2/7] bisect--helper: reimplement `bisect_replay` shell function in C

From: Miriam R. <mirucam@gmail.com>
Date: Jan 25, 2021, 19:18 UTC
Message-ID: <CAN7CjDC-GdA00jWJn=cKiu-Y1AXKSOJ-Uav7ZMyeGHVSBV5HqA@mail.gmail.com>
In-Reply-To: <xmqq35yr2nh0.fsf@gitster.c.googlers.com>

Hi Junio,

El dom, 24 ene 2021 a las 1:22, Junio C Hamano (<gitster@pobox.com>) escribió:

Show 23 quoted lines

>
> Miriam Rubio <mirucam@gmail.com> writes:
>
> > From: Pranit Bauva <pranit.bauva@gmail.com>
> >
> > Reimplement the `bisect_replay` shell function in C and also add
> > `--bisect-replay` subcommand to `git bisect--helper` to call it from
> > git-bisect.sh
> > ...
> > +static int process_replay_line(struct bisect_terms *terms, struct strbuf *line)
> > +{
> > +     const char *p = line->buf + strspn(line->buf, " \t");
> > +
> > +     if ((!skip_prefix(p, "git bisect", &p) &&
> > +     !skip_prefix(p, "git-bisect", &p)) || !isspace(*p))
> > +             return 0;
> > +     p += strspn(p, " \t");
> > +
> > +     char *word_end = (char*)p + strcspn(p, " \t");
> > +     char *rev = word_end + strspn(word_end, " \t");
>
> Are these lines new in this round?
>

Yes, they are a reviewer's suggestion.

> These break builds with -Werror=declaration-after-statement.
>

Sorry about this, my compiler sometimes does not alert with some -Werror. I have just sent a new version. Best, Miriam