Re: [PATCH v2 0/3] clang-format: modify rules to reduce false-positives

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2025, 20:49 UTC
Message-ID: <xmqqcyajk55k.fsf@gitster.g>
In-Reply-To: <878ql8qbhp.fsf@iotcl.com>

Toon Claes <toon@iotcl.com> writes:

>>   -#define PATHSPEC_NO_REPOSITORY (1<<7)
>>   +#define PATHSPEC_NO_REPOSITORY (1 << 7)
>
> I'm surprised, but I couldn't find a setting to change this...

We do not mind spaces around binary operators like "<<", and the change suggested by the tool is an improvement in this case, I think. The lack of U suffix to ensure that a bitmask is unsigned bothers me more, but that is not formatting issue.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.