Re: [PATCH v2 0/3] clang-format: modify rules to reduce false-positives
- From
Toon Claes <toon@iotcl.com>
- Date
- Jul 1, 2025, 13:36 UTC
- Message-ID
- <878ql8qbhp.fsf@iotcl.com>
- In-Reply-To
- <20250630-525-make-clang-format-more-robust-v2-0-05cbcdbf7817@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 13 quoted lines
> This series is in response to an email thread [1] around the usage of > '.clang-format' and its effectiveness. > > The goal of the series is to improve the usage of 'clang-format' in the > repository. To do this we: > 1. Reduce the number of false positives. Majority of which is due to > line-wrapping. We remove the 'ColumnLimit' from 'clang-format'. This > removes the responsibility of line-wrapping from 'clang-format' and puts > it into the hands of the user. > 2. Add a rule to 'meson' to run 'git clang-format' by running 'meson > compile style'. > 3. Make the 'RemoveBracesLLVM' permanent by moving it to > '.clang-format'.
Thanks for working on this. While the changes are not huge, I appreciate them.
Show 15 quoted lines
> With this, running `git clang-format` for the last 25 commits in master,
> seems to produce much less false positives.
>
> [snip]
>
> diff --git a/pathspec.h b/pathspec.h
> index 5e3a6f1fe7..601b9ca201 100644
> --- a/pathspec.h
> +++ b/pathspec.h
> @@ -80,7 +80,7 @@ struct pathspec {
> * For git diff --no-index, indicate that we are operating without
> * a repository or index.
> */
> -#define PATHSPEC_NO_REPOSITORY (1<<7)
> +#define PATHSPEC_NO_REPOSITORY (1 << 7)I'm surprised, but I couldn't find a setting to change this...
-- Cheers, Toon