Re: [PATCH v2 3/3] meson: add rule to run 'git clang-format'

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2025, 16:02 UTC
Message-ID: <xmqq5xgblx0v.fsf@gitster.g>
In-Reply-To: <aGO00T4c2Q-EYXZx@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 14 quoted lines

>> +git_clang_format = find_program('git-clang-format', required: false)
>> +if git_clang_format.found()
>> +  run_target('style',
>> +    command: [
>> +      'git', 'clang-format',
>> +      '--style', 'file',
>> +      '--diff',
>> +      '--extensions', 'c,h'
>> +    ]
>> +  )
>> +endif
>
> Do we want to call this target `clang-format-changed` though, so that it
> is consistent with the implicit `clang-format` target?

It think this is trying to be consistent with the 'make style' target.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.