Re: [PATCH 17/19] Portable alloca for Git

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2014, 17:30 UTC
Message-ID: <xmqqbnw9xfbb.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CABPQNSbiyzGLC=Y1kiFPOc4WLWnu=ZpPd6aRwSBzBjZYEih5Tw@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 16 quoted lines

>> Subject: [PATCH] mingw: activate alloca
>>
>> Both MSVC and MINGW have alloca(3) definitions in malloc.h, so by moving
>> win32-compat alloca.h from compat/vcbuild/include/ to compat/win32/ ,
>> which is included by both MSVC and MINGW CFLAGS, we can make alloca()
>> work on both those Windows environments.
>>
>> In MINGW, malloc.h has explicit check for GNUC and if it is so, defines
>> alloca to __builtin_alloca, so it looks like we don't need to add any
>> code to here-shipped alloca.h to get optimum performance.
>>
>> Compile-tested on Windows in MSysGit.
>>
>> Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
>
> Looks good to me!

Thanks; queued and pushed out on 'next'.