Re: [PATCH 17/19] Portable alloca for Git

From: Kirill Smelkov <kirr@mns.spb.ru>
Date: Feb 28, 2014, 17:00 UTC
Message-ID: <20140228170012.GA5247@tugrik.mns.mnsspb.ru>
In-Reply-To: <CABPQNSadTGfiue6G+6x7_o10Ri1E7D5vZFU=Cp8rAha+j9jwSA@mail.gmail.com>

On Fri, Feb 28, 2014 at 02:50:04PM +0100, Erik Faye-Lund wrote:

Show 24 quoted lines

> On Fri, Feb 28, 2014 at 2:44 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> > On Mon, Feb 24, 2014 at 5:21 PM, Kirill Smelkov <kirr@mns.spb.ru> wrote:
> >> diff --git a/Makefile b/Makefile
> >> index dddaf4f..0334806 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -316,6 +321,7 @@ endif
> >>  ifeq ($(uname_S),Windows)
> >>         GIT_VERSION := $(GIT_VERSION).MSVC
> >>         pathsep = ;
> >> +       HAVE_ALLOCA_H = YesPlease
> >>         NO_PREAD = YesPlease
> >>         NEEDS_CRYPTO_WITH_SSL = YesPlease
> >>         NO_LIBGEN_H = YesPlease
> >
> > In MSVC, alloca is defined in in malloc.h, not alloca.h:
> >
> > http://msdn.microsoft.com/en-us/library/wb1s57t5.aspx
> >
> > In fact, it has no alloca.h at all. But we don't have malloca.h in
> > mingw either, so creating a compat/win32/alloca.h that includes
> > malloc.h is probably sufficient.
> 
> "But we don't have alloca.h in mingw either", sorry.

Don't we have that for MSVC already in

    compat/vcbuild/include/alloca.h

and

    ifeq ($(uname_S),Windows)
        ...
        BASIC_CFLAGS = ... -Icompat/vcbuild/include ...

in config.mak.uname ?

And as I've not touched MINGW part in config.mak.uname the patch stays valid as it is :) and we can incrementally update what platforms have working alloca with follow-up patches.

In fact that would be maybe preferred, for maintainers to enable alloca with knowledge and testing, as one person can't have them all at hand.

Thanks, Kirill