Re: [PATCH 17/19] Portable alloca for Git

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Feb 28, 2014, 13:50 UTC
Message-ID: <CABPQNSadTGfiue6G+6x7_o10Ri1E7D5vZFU=Cp8rAha+j9jwSA@mail.gmail.com>
In-Reply-To: <CABPQNSaVQuXBEnSrs6hdHwEbaBKFr-NjKpuBRNnbkM+HtfJ4Ag@mail.gmail.com>

On Fri, Feb 28, 2014 at 2:44 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:

Show 21 quoted lines

> On Mon, Feb 24, 2014 at 5:21 PM, Kirill Smelkov <kirr@mns.spb.ru> wrote:
>> diff --git a/Makefile b/Makefile
>> index dddaf4f..0334806 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -316,6 +321,7 @@ endif
>>  ifeq ($(uname_S),Windows)
>>         GIT_VERSION := $(GIT_VERSION).MSVC
>>         pathsep = ;
>> +       HAVE_ALLOCA_H = YesPlease
>>         NO_PREAD = YesPlease
>>         NEEDS_CRYPTO_WITH_SSL = YesPlease
>>         NO_LIBGEN_H = YesPlease
>
> In MSVC, alloca is defined in in malloc.h, not alloca.h:
>
> http://msdn.microsoft.com/en-us/library/wb1s57t5.aspx
>
> In fact, it has no alloca.h at all. But we don't have malloca.h in
> mingw either, so creating a compat/win32/alloca.h that includes
> malloc.h is probably sufficient.

"But we don't have alloca.h in mingw either", sorry.