Re: [PATCH] push: change submodule default to check

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2016, 18:02 UTC
Message-ID: <xmqqbmz0uh54.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqfuocuh92.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> +static void preset_submodule_default(void)
>> +{
>> +	if (file_exists(".gitmodules"))
>
> Don't we need to see if we are in a bare repository?
>
>> +		recurse_submodules = RECURSE_SUBMODULES_CHECK;
>> +	else
>> +		recurse_submodules = RECURSE_SUBMODULES_DEFAULT;
>
> Hmph, why "_DEFAULT" not "_OFF"?

... because you wanted to keep the same behaviour, i.e. keep recurse_submodules set to _DEFAULT just like the compiled-in initialization does.

Perhaps we can lose "else" clause altogether?