Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Oct 7, 2016, 12:41 UTC
- Message-ID
- <20161007124157.GA61543@book.hvoigt.net>
- In-Reply-To
- <CAGZ79ka=bVX51wrSiz4u7xOy+54t+v7a-iU5dHtQoNnB7-NAkw@mail.gmail.com>
On Thu, Oct 06, 2016 at 10:20:16AM -0700, Stefan Beller wrote:
Show 21 quoted lines
> On Thu, Oct 6, 2016 at 2:23 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote: > > On Wed, Oct 05, 2016 at 03:53:25PM +0200, Heiko Voigt wrote: > >> On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: > >> > Jeff, > >> > thanks for the suggestions, both git_path(..) as well as checking the config, > >> > this seems quite readable to me: > >> > >> When reading the discussion I thought the same: What about the > >> "old-style" repositories. I like this one. Checking both locations > >> is nice. > > > > BTW, since it seems we all agree on the direction. Should we add some > > tests? > > > > Good call. What do we want to test for? > * Correctness in case of submodules? (just push and get rejected) > I think that is easy to do. > * Performance with [no, lots of] submodules? That seems harder to me. > > I'll add a test for the correctness part and resend.
Well I though about the following tests:
* Without submodules: Make sure submodule processing is disabled by default * With new-style submodules: Make sure submodules are processed by default * With old-style submodules: Make sure submodules are processed by default
But I have to admit that I did not think about the "how can we do that". But performance seems to be the only thing that is exposing the processing when we have no submodules, so it seems we can only easily do the tests with submodules.
Cheers Heiko