Re: [PATCH 05/14] packed-graph: implement construct_graph()

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2018, 20:47 UTC
Message-ID: <xmqqbmhg73fg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kaNj-+oBNmbTKtOE8P-ZFcBVZSaBtwzrB4RQTWnYXcoqA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 8 quoted lines

> On Thu, Jan 25, 2018 at 6:02 AM, Derrick Stolee <stolee@gmail.com> wrote:
>
>> +struct object_id *construct_graph(const char *pack_dir)
>> +{
>> +       // Find a list of oids, adding the pointer to a list.
>
> Comment style.
> Here is where the bike shedding begins. ;)

I also saw some violations of the usual formatting conventions, e.g.

	if (condition) {
		block

should not be

	if (condition)
	{
		block

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.