Re: [PATCH 03/14] packed-graph: create git-graph builtin
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jan 26, 2018, 14:16 UTC
- Message-ID
- <CACsJy8BS3Gi2rZq=JXz+o+g4cOJCg0sKShqSG0p9kFXCjwNtWg@mail.gmail.com>
- In-Reply-To
- <37d84775-174f-02fc-159c-0810df458b5a@gmail.com>
On Fri, Jan 26, 2018 at 8:14 PM, Derrick Stolee <stolee@gmail.com> wrote:
Show 20 quoted lines
> On 1/25/2018 6:01 PM, Junio C Hamano wrote: >> >> Derrick Stolee <stolee@gmail.com> writes: >> >>> Teach Git the 'graph' builtin that will be used for writing and >>> reading packed graph files. The current implementation is mostly >>> empty, except for a check that the core.graph setting is enabled >>> and a '--pack-dir' option. >> >> Just to set my expectation straight. >> >> Is it fair to say that in the ideal endgame state, this will be like >> "git pack-objects" in that end users won't have to know about it, >> but would serve as a crucial building block that is invoked by other >> front-end commands that are more familiar to end users (just like >> pack-objects are used behind the scenes by repack, push, etc.)? > > > That is my hope. Leaving that integration for later, after this feature has > proven itself.
Then I suggest you use a more specific command name (commit-graph? packed-graph?) and leave the pretty name "graph" out, it could be used for some UI-facing thing someday, maybe.
-- Duy