Re: [PATCH 09/14] packed-graph: implement git-graph --clear

From: Stefan Beller <sbeller@google.com>
Date: Jan 25, 2018, 23:35 UTC
Message-ID: <CAGZ79kY9GD+ZiFCmAfUsJOqYOQg_a8FUzCiKwVST-_oLUPSnHg@mail.gmail.com>
In-Reply-To: <20180125140231.65604-10-dstolee@microsoft.com>

On Thu, Jan 25, 2018 at 6:02 AM, Derrick Stolee <stolee@gmail.com> wrote:

Show 6 quoted lines

> Teach Git to delete the current 'graph_head' file and the packed graph
> it references. This is a good safety valve if somehow the file is
> corrupted and needs to be recalculated. Since the packed graph is a
> summary of contents already in the ODB, it can be regenerated.
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>

Show 9 quoted lines

>  static int graph_read(void)
>  {
>         struct object_id graph_oid;
> @@ -105,6 +130,8 @@ int cmd_graph(int argc, const char **argv, const char *prefix)
>                 { OPTION_STRING, 'p', "pack-dir", &opts.pack_dir,
>                         N_("dir"),
>                         N_("The pack directory to store the graph") },
> +               OPT_BOOL('c', "clear", &opts.clear,
> +                       N_("clear graph file and graph-head")),

Given the docs building up a large list of "Cannot be combined with", maybe these OPT_BOOLS want to be OPT_CMDMODE ?