Re: [PATCH 00/14] Serialized Commit Graph

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jan 25, 2018, 15:46 UTC
Message-ID: <871siex7pc.fsf@evledraar.gmail.com>
In-Reply-To: <20180125140231.65604-1-dstolee@microsoft.com>

On Thu, Jan 25 2018, Derrick Stolee jotted:

Show 11 quoted lines

> * 'git log --topo-order -1000' walks all reachable commits to avoid
>   incorrect topological orders, but only needs the commit message for
>   the top 1000 commits.
>
> * 'git merge-base <A> <B>' may walk many commits to find the correct
>   boundary between the commits reachable from A and those reachable
>   from B. No commit messages are needed.
>
> * 'git branch -vv' checks ahead/behind status for all local branches
>   compared to their upstream remote branches. This is essentially as
>   hard as computing merge bases for each.

This is great, spotted / questions so far:

* git graph --blah says you need to enable the config, should say
  "unknown option --blah <help>". I.e. overzelous config guard.

* On a big repo (git show-ref -s | ~/g/git/git-graph --write
  --update-head) is as of writing this still hanging for me, but strace
  shows it's brk()-ing. Presumably just still busy, a progress bar would
  be very nice.

* Shouldn't there be a pack.useGraph option so this gets auto-updated on
  repack? I understand this series is a WIP, so that's more a "is that
  the UI" than "it needs now".