Re: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 29, 2018, 21:52 UTC
Message-ID: <xmqqbmbttg4i.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180629161223.229661-2-dstolee@microsoft.com>

Derrick Stolee <dstolee@microsoft.com> writes:

Show 8 quoted lines

> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
>  Makefile       |   1 +
>  commit-reach.c | 359 +++++++++++++++++++++++++++++++++++++++++++++++++
>  commit-reach.h |  41 ++++++
>  commit.c       | 358 ------------------------------------------------
>  4 files changed, 401 insertions(+), 358 deletions(-)
>  create mode 100644 commit-reach.c

"blame -bs -C HEAD^.." tells us that all lines except for the initial #include of this file came from commit.c verbatim, which is good for a "move lines" patch like this one.

>  create mode 100644 commit-reach.h

"blame -bs -C -C HEAD^.." tells us, but "blame -bs -C HEAD^.." does not tell us, that most of the lines are from commit.h, which is a very bad sign. reduce_heads(), for example, have two duplicated decl and depending on which header file is included, the source files will risk getting inconsistent definition once the headers start to deviate from each other.