Re: [RFC PATCH 06/13] commit-reach: move can_all_from_reach_with_flag()

From: Stefan Beller <sbeller@google.com>
Date: Jun 29, 2018, 21:47 UTC
Message-ID: <CAGZ79kYR1yHxkcDTJh7YoNJydkE_WhdL1mdMKL3hDXgEk+gLxw@mail.gmail.com>
In-Reply-To: <20180629161223.229661-7-dstolee@microsoft.com>

Hi Derrick,

> +static int reachable(struct commit *from, int with_flag, int assign_flag, time_t min_commit_date)

[...]

> +               if (commit->date < min_commit_date)
> +                       continue;

[...]

> +int can_all_from_reach_with_flag(struct object_array from,
> +                                int with_flag, int assign_flag,
> +                                time_t min_commit_date)

Can you expand on why we introduce the min_commit_date in the commit message? (It looks like a rebase error as I would have expected a move only, given the subject)

Thanks, Stefan

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.