git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 03/13] commit-reach: move commit_contains from ref-filter

From
Derrick Stolee <stolee@gmail.com>
Date
Jun 30, 2018, 01:32 UTC
Message-ID
<74071f5d-af5c-a125-3125-f52dd0977cb4@gmail.com>
In-Reply-To
<CAGZ79kbMks+U94-==SB48DoSpYQOpa-bn_yJBjW7zH3cCCotng@mail.gmail.com>
On 6/29/2018 5:38 PM, Stefan Beller wrote:
Show 10 quoted lines
> Hi Derrick,
>
>> +struct ref_filter_cbdata {
>> +       struct ref_array *array;
>> +       struct ref_filter *filter;
>> +       struct contains_cache contains_cache;
>> +       struct contains_cache no_contains_cache;
> These members also seem to be moved whitespace-inconsistently.
> Could you clarify in the commit message that you re-indent them or
> what happened?

Sorry, there appears to be something strange that happens when I paste into vim that causes my whitespace to mess up, especially leading whitespace. Usually `git rebase --whitespace=fix` fixes it.

I'll be more careful in my next replay of the series.
Previous: Stefan BellerNext: Junio C Hamano
Message 8 of 29 in “Consolidate reachability logic”
  1. 00/13 Consolidate reachability logicDerrick Stolee, Jun 29, 2018
  2. 01/13 commit-reach: move walk methods from commit.cDerrick Stolee, Jun 29, 2018
  3. Stefan BellerJun 29, 2018
  4. Junio C HamanoJun 29, 2018
  5. 02/13 commit-reach: move ref_newer from remote.cDerrick Stolee, Jun 29, 2018
  6. 03/13 commit-reach: move commit_contains from ref-filterDerrick Stolee, Jun 29, 2018
  7. Stefan BellerJun 29, 2018
  8. Derrick StoleeJun 30, 2018
  9. Junio C HamanoJun 29, 2018
  10. 04/13 upload-pack: make reachable() more genericDerrick Stolee, Jun 29, 2018
  11. Junio C HamanoJun 29, 2018
  12. 06/13 commit-reach: move can_all_from_reach_with_flag()Derrick Stolee, Jun 29, 2018
  13. Stefan BellerJun 29, 2018
  14. Derrick StoleeJun 30, 2018
  15. 10/13 commit-reach: test is_descendant_ofDerrick Stolee, Jun 29, 2018
  16. 09/13 commit-reach: test can_all_from_reachDerrick Stolee, Jun 29, 2018
  17. 12/13 commit-reach: use is_descendant_of for ref_newerDerrick Stolee, Jun 29, 2018
  18. 13/13 commit-reach: use can_all_from_reachDerrick Stolee, Jun 29, 2018
  19. Stefan BellerJun 29, 2018
  20. 08/13 test-reach: test reduce_heads()Derrick Stolee, Jun 29, 2018
  21. Stefan BellerJun 29, 2018
  22. 11/13 commit-reach: make can_all_from_reach... linearDerrick Stolee, Jun 29, 2018
  23. Stefan BellerJun 29, 2018
  24. 05/13 upload-pack: refactor ok_to_give_up()Derrick Stolee, Jun 29, 2018
  25. Stefan BellerJun 29, 2018
  26. 07/13 test-reachDerrick Stolee, Jun 29, 2018
  27. Stefan BellerJun 29, 2018
  28. Derrick StoleeJun 30, 2018
  29. Derrick StoleeJun 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.