Re: [PATCH] sequencer.c: terminate the last line of author-script properly

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 26, 2018, 17:44 UTC
Message-ID: <xmqqbmatrixc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1807261347040.71@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 17 quoted lines

> Hi Junio,
>
> On Tue, 17 Jul 2018, Junio C Hamano wrote:
>
>> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
>> index 2d189da2f1..b0cef509ab 100755
>> --- a/t/t3404-rebase-interactive.sh
>> +++ b/t/t3404-rebase-interactive.sh
>> @@ -81,11 +81,13 @@ test_expect_success 'rebase -i writes out .git/rebase-merge/author-script in "ed
>
> You missed a very long line here.
>
>>  	set_fake_editor &&
>>  	FAKE_LINES="edit 1" git rebase -i HEAD^ &&
>>  	test -f .git/rebase-merge/author-script &&
>
> Why do we need this, if we already have an `eval` later on?

You are commenting on a wrong version.  Comment on the original.