Re: [PATCH] sequencer.c: terminate the last line of author-scriptproperly

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2018, 17:24 UTC
Message-ID: <xmqq36wglamv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <eb295aea-dae5-5e1c-bacf-2c77d3ce0195@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

Show 8 quoted lines

>> The only consumer of a faulty author script written by the sequencer
>> is read_env_script() in sequencer.c which doesn't worry about
>> checking that quotes are paired. 
>
> That's not quite true anymore, recently another consumer
> read_author_ident() was added which uses sq_dequote() instead of
> custom code. Looking more closely at write_author_script() the quoting
> of single quotes is buggy they are escaped as \\' instead of \'.

That's embarrassing re-invention (instead of reuse) with additional bug X-<. It seems that all of that blame to d87d48b2 ("sequencer: learn about the special "fake root commit" handling", 2018-05-04).

We should fix both broken writer and readers that compensate for breakage in the writer, I guess. Sigh...