Re: [PATCH] sequencer.c: terminate the last line of author-script properly

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2018, 17:17 UTC
Message-ID: <xmqq7elslayl.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <eb66f8fb-1535-37a8-526d-ed31f06c045c@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

Show 7 quoted lines

>> (I think we had code to do so in "git am"
>> that was rewritten in C first).
>
> The code in builtin/am.c doesn't try to write valid posix shell (if
> one assumes it is the only consumer of the author script then it
> doesn't need to) which results in simpler code, but external scripts
> cannot safely eval it anymore.

Are you sure about that? If so we probably should see if we can fix the writer, and better yet, if we can share code with the writer discussed here, as presumably we are fixing it in this thread.

But I do not see how builtin/am.c::write_author_script() would produce something that would not eval correctly. sq_quote_buf() was introduced specifically to write correct string for shell's consumption.