Re: [PATCH] sequencer.c: terminate the last line of author-script properly

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 27, 2018, 15:49 UTC
Message-ID: <nycvar.QRO.7.76.6.1807271749290.10478@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqbmatrixc.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 26 Jul 2018, Junio C Hamano wrote:

Show 21 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Hi Junio,
> >
> > On Tue, 17 Jul 2018, Junio C Hamano wrote:
> >
> >> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
> >> index 2d189da2f1..b0cef509ab 100755
> >> --- a/t/t3404-rebase-interactive.sh
> >> +++ b/t/t3404-rebase-interactive.sh
> >> @@ -81,11 +81,13 @@ test_expect_success 'rebase -i writes out .git/rebase-merge/author-script in "ed
> >
> > You missed a very long line here.
> >
> >>  	set_fake_editor &&
> >>  	FAKE_LINES="edit 1" git rebase -i HEAD^ &&
> >>  	test -f .git/rebase-merge/author-script &&
> >
> > Why do we need this, if we already have an `eval` later on?
> 
> You are commenting on a wrong version.  Comment on the original.

Sorry, no time. Take this review, or leave it.

Ciao, Dscho