Re: [PATCH 2/5] t5303: test some corrupt deltas

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2018, 21:39 UTC
Message-ID: <xmqqbm9i1aih.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180831194727.GA5120@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

>> So instead of typing 3 lines, you can just say "yes we use echo that
>> emulates Unix".
>
> I actually found Dscho's response much more informative than a simple
> yes/no.
>
> At any rate, it sounds like we are probably OK with echo, but I think it
> is still worth doing the defensive patch-on-top that I posted.

Actually, Dscho's footnote was much more informative than the "echo is from UNIX, dammit" that didn't convey anything useful---yes, we all know that echo is from UNIX, but what does he do to it? Does he want it to be like UNIX, or want to tweak it to suit Windows taste?

Reading the footnote again, from there, you can read that 'echo' may currently behave like UNIX, but he guarantees that it can change any time without notice; in his mind, 'echo' in the ideal world in the fiture on Windows is to use CRLF.

So we must protect the test from his whim by using printf.