Re: [PATCH 2/5] t5303: test some corrupt deltas
- From
Jeff King <peff@peff.net>
- Date
- Aug 31, 2018, 19:47 UTC
- Message-ID
- <20180831194727.GA5120@sigill.intra.peff.net>
- In-Reply-To
- <xmqqh8ja360p.fsf@gitster-ct.c.googlers.com>
On Fri, Aug 31, 2018 at 08:33:26AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> Would "echo base >base" give us 5-byte long base even on Windows? > > > > Please note that Unix shell scripting is a foreign thing on Windows. As > > such, there is not really any "native" shell we can use [*1*], and > > Yeah, I know that; otherwise I wouldn't have asked. Because ... > > > therefore we use MSYS2's Bash which outputs Unix line endings. > > ... I didn't know what MSYS folks chose, and/or if you have chosen > to tweak their choice, and/or if you switched to somebody else's shell > (e.g. busybox) and/or you chose to tweak what they do out of the box, > it was worth asking and getting yes/no question. You do not have to > tell me why I should be asking. > > So instead of typing 3 lines, you can just say "yes we use echo that > emulates Unix".
I actually found Dscho's response much more informative than a simple yes/no.
At any rate, it sounds like we are probably OK with echo, but I think it is still worth doing the defensive patch-on-top that I posted.
-Peff