git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] t5303: add tests for corrupted deltas

From
Jann Horn <jannh@google.com>
Date
Aug 29, 2018, 20:58 UTC
Message-ID
<20180829205857.77340-3-jannh@google.com>
In-Reply-To
<20180829205857.77340-1-jannh@google.com>
This verifies the changes from commit "patch-delta: fix oob read".
Signed-off-by: Jann Horn <jannh@google.com>
---
 t/t5303-pack-corruption-resilience.sh | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
diff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh
index 3634e258f..7152376b6 100755
--- a/t/t5303-pack-corruption-resilience.sh
+++ b/t/t5303-pack-corruption-resilience.sh
@@ -311,4 +311,22 @@ test_expect_success \
      test_must_fail git cat-file blob $blob_2 > /dev/null &&
      test_must_fail git cat-file blob $blob_3 > /dev/null'
 
+test_expect_success \
+    'apply good minimal delta' \
+    'printf "\x00\x01\x01X" > minimal_delta &&
+     test-tool delta -p /dev/null minimal_delta /dev/null
+     '
+
+test_expect_success \
+    'apply truncated delta' \
+    'printf "\x00\x02\x02X" > truncated_delta &&
+     test_must_fail test-tool delta -p /dev/null truncated_delta /dev/null
+     '
+
+test_expect_success \
+    'apply delta with trailing garbage command' \
+    'printf "\x00\x01\x01X\x01" > tail_garbage_delta &&
+     test_must_fail test-tool delta -p /dev/null tail_garbage_delta /dev/null
+     '
+
 test_done
-- 
2.19.0.rc0.228.g281dcd1b4d0-goog
Previous: Jeff KingNext: Jeff King
Message 7 of 31 in “patch-delta: fix oob read”
  1. 1/3 patch-delta: fix oob readJann Horn, Aug 29, 2018
  2. 2/3 t/helper/test-delta: segfault on OOB accessJann Horn, Aug 29, 2018
  3. Jeff KingAug 29, 2018
  4. Jann HornAug 29, 2018
  5. Jeff KingAug 29, 2018
  6. Jeff KingAug 29, 2018
  7. 3/3 t5303: add tests for corrupted deltasJann Horn, Aug 29, 2018
  8. Jeff KingAug 29, 2018
  9. Jeff KingAug 29, 2018
  10. Jeff KingAug 29, 2018
  11. Jeff KingAug 29, 2018
  12. 0/5 handle corruption in patch-deltaJeff King, Aug 30, 2018
  13. 1/5 test-delta: read input into a heap bufferJeff King, Aug 30, 2018
  14. 2/5 t5303: test some corrupt deltasJeff King, Aug 30, 2018
  15. Junio C HamanoAug 30, 2018
  16. Jeff KingAug 30, 2018
  17. Jeff KingAug 30, 2018
  18. Junio C HamanoAug 30, 2018
  19. Jeff KingAug 30, 2018
  20. Johannes SchindelinAug 31, 2018
  21. Junio C HamanoAug 31, 2018
  22. Jeff KingAug 31, 2018
  23. Junio C HamanoAug 31, 2018
  24. Johannes SchindelinAug 31, 2018
  25. Jeff KingAug 31, 2018
  26. Junio C HamanoAug 31, 2018
  27. 3/5 patch-delta: fix oob readJeff King, Aug 30, 2018
  28. 4/5 patch-delta: consistently report corruptionJeff King, Aug 30, 2018
  29. 5/5 patch-delta: handle truncated copy parametersJeff King, Aug 30, 2018
  30. Jann HornAug 30, 2018
  31. Nicolas PitreAug 30, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.