Re: [PATCH 2/5] t5303: test some corrupt deltas

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 31, 2018, 09:58 UTC
Message-ID: <nycvar.QRO.7.76.6.1808311155410.71@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq8t4n69gy.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 30 Aug 2018, Junio C Hamano wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > +test_expect_success \
> > +    'apply delta with too many copied bytes' \
> > +    'printf "\5\1\221\0\2" > too_big_copy &&
> > +     echo base >base &&
> > +     test_must_fail test-tool delta -p base too_big_copy /dev/null'
> 
> Would "echo base >base" give us 5-byte long base even on Windows?

Please note that Unix shell scripting is a foreign thing on Windows. As such, there is not really any "native" shell we can use [*1*], and therefore we use MSYS2's Bash which outputs Unix line endings.

Ciao, Dscho

Footnote *1*: I keep trying (and failing) to find the time to work on the pure-Win32 port of BusyBox, which would give us "sort of a native Unix shell". That probably *would* output CR/LF in this case. But as there are still parts of the test suite that require Perl (which is not included in BusyBox), I think we are still a loooong way from running the test suite in a pure Win32 fashion. With all the time tax that incurs for us Windows users.