git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] .gitattributes: ensure t/oid-info/* has eol=lf

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 14, 2018, 02:23 UTC
Message-ID
<xmqqbm5oethq.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<6d6ca9a2-9245-e5e9-6d7a-e6d3004054bb@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 16 quoted lines
>> FWIW, I personally do not think "is sensitive to CRLF" is too bad,
>> as my attempt to clarify it does not make it much better, e.g.
>>
>> 	The logic to read from these files in shell uses built-in
>> 	"read" command, which leaves CR at the end of these text
>> 	files when they are checked out with CRLF line endings, at
>> 	least when run with bash shipped with Git for Windows.  This
>> 	results in an unexpected value in the variable these lines
>> 	are read into, leading the tests to fail.
>>
>> So, I'll keep what I queued when I received v1 for now.
>
> Sorry for missing the edit to the message. You are correct that v2
> just added one commit.
>
> I like your rewording, if you feel like editing it.
I'm kinda neutral ;-).
Previous: Derrick StoleeNext: brian m. carlson
Message 12 of 16 in “.gitattributes: ensure t/oid-info/* has eol=lf”
  1. 0/1 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 11, 2018
  2. 1/1 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 11, 2018
  3. SZEDER GáborDec 12, 2018
  4. Johannes SchindelinDec 13, 2018
  5. SZEDER GáborDec 13, 2018
  6. Johannes SchindelinDec 13, 2018
  7. Junio C HamanoDec 12, 2018
  8. 0/2 Add more eol=lf to .gitattributesDerrick Stolee via GitGitGadget, Dec 12, 2018
  9. 1/2 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 12, 2018
  10. Junio C HamanoDec 13, 2018
  11. Derrick StoleeDec 13, 2018
  12. Junio C HamanoDec 14, 2018
  13. brian m. carlsonDec 14, 2018
  14. Johannes SchindelinDec 14, 2018
  15. 2/2 t4256: mark support files as LF-onlyJohannes Schindelin via GitGitGadget, Dec 12, 2018
  16. Junio C HamanoDec 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.