git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Add more eol=lf to .gitattributes

From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 12, 2018, 18:14 UTC
Message-ID
<pull.98.v2.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.98.git.gitgitgadget@gmail.com>

I noticed that our CI builds (see [1] for an example) were returning success much faster than they did before Git v2.20.0. Turns out that there was a test script failure involving the new test hash logic.

error: bug in the test script: bad hash algorithm make[1]: *** [Makefile:56: t0000-basic.sh] Error 1 make[1]: *** Waiting for unfinished jobs....

This failure was due to an LF -> CRLF conversion in some data files in t/oid-info/. Don't munge these files, and the tests can continue.

UPDATED IN V2: Unfortunately, I didn't check the full test suite after getting beyond this point, and found another LF -> CRLF conversion problem in t4256-am-format-flowed.sh due to example patches in t/t4256/1/. Add these in a second commit. Thanks, dscho, for helping with the correct placement.

Thanks, -Stolee
[1] https://gvfs.visualstudio.com/ci/_build/results?buildId=4815
Derrick Stolee (1):
  .gitattributes: ensure t/oid-info/* has eol=lf
Johannes Schindelin (1):
  t4256: mark support files as LF-only
 .gitattributes   | 1 +
 t/.gitattributes | 1 +
 2 files changed, 2 insertions(+)
base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-98%2Fderrickstolee%2Ftest-oid-fix-windows-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-98/derrickstolee/test-oid-fix-windows-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/98
Range-diff vs v1:
 1:  4a22502a31 = 1:  4a22502a31 .gitattributes: ensure t/oid-info/* has eol=lf
 -:  ---------- > 2:  4275b8a581 t4256: mark support files as LF-only
-- 
gitgitgadget
Previous: Junio C HamanoNext: Derrick Stolee via GitGitGadget
Message 8 of 16 in “.gitattributes: ensure t/oid-info/* has eol=lf”
  1. 0/1 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 11, 2018
  2. 1/1 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 11, 2018
  3. SZEDER GáborDec 12, 2018
  4. Johannes SchindelinDec 13, 2018
  5. SZEDER GáborDec 13, 2018
  6. Johannes SchindelinDec 13, 2018
  7. Junio C HamanoDec 12, 2018
  8. 0/2 Add more eol=lf to .gitattributesDerrick Stolee via GitGitGadget, Dec 12, 2018
  9. 1/2 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 12, 2018
  10. Junio C HamanoDec 13, 2018
  11. Derrick StoleeDec 13, 2018
  12. Junio C HamanoDec 14, 2018
  13. brian m. carlsonDec 14, 2018
  14. Johannes SchindelinDec 14, 2018
  15. 2/2 t4256: mark support files as LF-onlyJohannes Schindelin via GitGitGadget, Dec 12, 2018
  16. Junio C HamanoDec 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.