git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] .gitattributes: ensure t/oid-info/* has eol=lf

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Dec 14, 2018, 00:51 UTC
Message-ID
<20181214005101.GT890086@genre.crustytoothpaste.net>
In-Reply-To
<4a22502a318a65f144b3b6542cc5e711a1811c78.1544638490.git.gitgitgadget@gmail.com>
On Wed, Dec 12, 2018 at 10:14:53AM -0800, Derrick Stolee via GitGitGadget wrote:
Show 24 quoted lines
> From: Derrick Stolee <dstolee@microsoft.com>
> 
> The new test_oid machinery in the test library requires reading
> some information from t/oid-info/hash-info and t/oid-info/oid.
> The shell logic that reads from these files is sensitive to CRLF
> line endings, causing a problem when the test suite is run on a
> Windows machine that converts LF to CRLF.
> 
> Exclude the files in this folder from this conversion.
> 
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
>  .gitattributes | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitattributes b/.gitattributes
> index acf853e029..3738cea7eb 100644
> --- a/.gitattributes
> +++ b/.gitattributes
> @@ -13,3 +13,4 @@
>  /Documentation/gitk.txt conflict-marker-size=32
>  /Documentation/user-manual.txt conflict-marker-size=32
>  /t/t????-*.sh conflict-marker-size=32
> +/t/oid-info/* eol=lf

Yeah, this seems like a sensible thing to do. I assumed the shell on Windows would read data as text files, not as binary files. It's kinda hard for me as a non-Windows user to predict what will need CRLF endings and what will need LF endings with Git on Windows.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Junio C HamanoNext: Johannes Schindelin
Message 13 of 16 in “.gitattributes: ensure t/oid-info/* has eol=lf”
  1. 0/1 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 11, 2018
  2. 1/1 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 11, 2018
  3. SZEDER GáborDec 12, 2018
  4. Johannes SchindelinDec 13, 2018
  5. SZEDER GáborDec 13, 2018
  6. Johannes SchindelinDec 13, 2018
  7. Junio C HamanoDec 12, 2018
  8. 0/2 Add more eol=lf to .gitattributesDerrick Stolee via GitGitGadget, Dec 12, 2018
  9. 1/2 .gitattributes: ensure t/oid-info/* has eol=lfDerrick Stolee via GitGitGadget, Dec 12, 2018
  10. Junio C HamanoDec 13, 2018
  11. Derrick StoleeDec 13, 2018
  12. Junio C HamanoDec 14, 2018
  13. brian m. carlsonDec 14, 2018
  14. Johannes SchindelinDec 14, 2018
  15. 2/2 t4256: mark support files as LF-onlyJohannes Schindelin via GitGitGadget, Dec 12, 2018
  16. Junio C HamanoDec 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.