Re: [PATCH 1/1] .gitattributes: ensure t/oid-info/* has eol=lf

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Dec 13, 2018, 13:22 UTC
Message-ID: <20181213132254.GW30222@szeder.dev>
In-Reply-To: <nycvar.QRO.7.76.6.1812131358530.43@tvgsbejvaqbjf.bet>

On Thu, Dec 13, 2018 at 02:01:15PM +0100, Johannes Schindelin wrote:

Show 22 quoted lines

> Hi Gábor,
> 
> On Wed, 12 Dec 2018, SZEDER Gábor wrote:
> 
> > On Tue, Dec 11, 2018 at 12:35:46PM -0800, Derrick Stolee via GitGitGadget wrote:
> > > From: Derrick Stolee <dstolee@microsoft.com>
> > > 
> > > The new test_oid machinery in the test library requires reading
> > > some information from t/oid-info/hash-info and t/oid-info/oid.
> > > The shell logic that reads from these files is sensitive to CRLF
> > > line endings, causing a problem when the test suite is run on a
> > > Windows machine that converts LF to CRLF.
> > 
> > "What problem?" is what people will ask when they read this commit
> > message in the future.
> 
> The test script (not test case) fails with the rather terrifying message
> 
> 	error: bug in the test script: bad hash algorithm
> 
> See e.g. line 958 of the Build & Test log in the Windows phase of
> https://dev.azure.com/git-for-windows/git/_build/results?buildId=26757

Yeah, I saw that in the cover letter. And that was my point, that I saw this there, not in the proposed commit log message:

> > Please include the relevant details in the commit message instead of
> > the cover letter.