Re: [PATCH v4 3/7] scalar: validate the optional enlistment argument

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2022, 17:35 UTC
Message-ID: <xmqqbkvuwxps.fsf@gitster.g>
In-Reply-To: <220517.867d6k6wjr.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> +test_expect_success '`scalar [...] <dir>` errors out when dir is missing' '
>> +	! scalar run config cloned 2>err &&
>
> Needs to use test_must_fail, not !

Good eyes and careful reading are very much appreciated, but in this case, doesn't such an improvement depend on an update to teach test_must_fail_acceptable about scalar being whitelisted?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.