From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 18 May 2022 17:35:11 GMT
Subject: Re: [PATCH v4 3/7] scalar: validate the optional enlistment argument
Message-ID: <xmqqbkvuwxps.fsf@gitster.g>
In-Reply-To: <220517.867d6k6wjr.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> +test_expect_success '`scalar [...] <dir>` errors out when dir is missing' '
>> +	! scalar run config cloned 2>err &&
>
> Needs to use test_must_fail, not !

Good eyes and careful reading are very much appreciated, but in this
case, doesn't such an improvement depend on an update to teach
test_must_fail_acceptable about scalar being whitelisted?