Re: [PATCH v4 3/7] scalar: validate the optional enlistment argument

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 25, 2022, 10:31 UTC
Message-ID: <nycvar.QRO.7.76.6.2205251224560.352@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqsfoyhgqe.fsf@gitster.g>

Hi Junio,

On Tue, 24 May 2022, Junio C Hamano wrote:

Show 23 quoted lines

> We can stop arguing and instead send in a reroll that squashes in
> something like this, which shouldn't be controversial, I would say.
>
>  t/test-lib-functions.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git i/t/test-lib-functions.sh w/t/test-lib-functions.sh
> index 93c03380d4..8899eaabed 100644
> --- i/t/test-lib-functions.sh
> +++ w/t/test-lib-functions.sh
> @@ -1106,7 +1106,7 @@ test_must_fail_acceptable () {
>  	fi
>
>  	case "$1" in
> -	git|__git*|test-tool|test_terminal)
> +	git|__git*|scalar|test-tool|test_terminal)
>  		return 0
>  		;;
>  	*)
>
>
>
>

It is still wrong to adjust Git's test suite for a user that is not part of Git proper. But if your pragmatism says that this is the only way we can venture on to more productive venues, I won't argue against that :-)

Ciao, Dscho