RE: [PATCH v4 0/7] scalar: implement the subcommand "diagnose"

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 19, 2022, 18:17 UTC
Message-ID: <nycvar.QRO.7.76.6.2205192013140.352@tvgsbejvaqbjf.bet>
In-Reply-To: <00f201d86a02$c6399150$52acb3f0$@nexbridge.com>

Hi Randall and Ævar,

On Tue, 17 May 2022, rsbecker@nexbridge.com wrote:

Show 14 quoted lines

> On May 17, 2022 11:03 AM, Ævar Arnfjörð Bjarmason wrote:
> >On Tue, May 10 2022, Johannes Schindelin via GitGitGadget wrote:
> >
> >> Over the course of the years, we developed a sub-command that gathers
> >> diagnostic data into a .zip file that can then be attached to bug
> >> reports. This sub-command turned out to be very useful in helping
> >> Scalar developers identify and fix issues.
> >
> >I don't mind this as some intermediate step, but re the context of the
> >plan for scalar "eventually going away" (discussed in previous threads)
> >I wonder why (especially re the earlier thread upthread at [1]) this
> >isn't being added to "git bugreport".
> >
> >Is the plan to integrate this into "git bugreport" eventually?

Potentially a variation of the `scalar diagnose` code could be useful in `git bugreport`, opt-in via a new option.

But that's not the purpose of this patch series.

> Could this also not be useful in fsck, as --diagnose? That's the go-to
> command when there are issues for many users.

I can see where you're coming from, but `fsck`'s mission is to verify the integrity of the local Git database. That is very different from the mission of `scalar diagnose`, which is to help diagnose issues (whether they are truly bugs or usage patterns causing unfortunate performance).

Ciao, Dscho