git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v2 3/4] t: move tests from reftable/record_test.c to the new unit test

From
Junio C Hamano <gitster@pobox.com>
Date
May 29, 2024, 22:38 UTC
Message-ID
<xmqqbk4otfae.fsf@gitster.g>
In-Reply-To
<Zlb1m5cwhW_R5EzP@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 7 quoted lines
>> +	strbuf_release(&a);
>> +	strbuf_release(&b);
>> +}
>
> Oh, so this test was even duplicated. It may make sense to point out
> details like this in the commit message to prepare the reader. But
> that's probably not worth a reroll.

Probably. But if you are sending out another round anyway, then it is a good opportunity to update the proposed log message.

;-)
Previous: Patrick SteinhardtNext: Chandra Pratap
Message 6 of 18 in “t: port reftable/basics_test.c to the unit testing”
  1. Chandra PratapMay 29, 2024
  2. [GSoC][PATCH v2 1/4] t: move reftable/basics_test.c to the unit testing frameworkChandra Pratap, May 29, 2024
  3. [GSoC][PATCH v2 2/4] t: move tests from reftable/stack_test.c to the new unit testChandra Pratap, May 29, 2024
  4. [GSoC][PATCH v2 3/4] t: move tests from reftable/record_test.c to the new unit testChandra Pratap, May 29, 2024
  5. Patrick SteinhardtMay 29, 2024
  6. Junio C HamanoMay 29, 2024
  7. [GSoC][PATCH v2 4/4] t: add test for put_be16() and improve test-case for parse_names()Chandra Pratap, May 29, 2024
  8. Patrick SteinhardtMay 29, 2024
  9. Patrick SteinhardtMay 29, 2024
  10. [GSoC][PATCH v3 0/4] t: port reftable/basics_test.c to the unit testingChandra Pratap, May 29, 2024
  11. [GSoC][PATCH v3 1/5] t: move reftable/basics_test.c to the unit testing frameworkChandra Pratap, May 29, 2024
  12. [GSoC][PATCH v3 2/5] t: move tests from reftable/stack_test.c to the new unit testChandra Pratap, May 29, 2024
  13. [GSoC][PATCH v3 3/5] t: move tests from reftable/record_test.c to the new unit testChandra Pratap, May 29, 2024
  14. [GSoC][PATCH v3 4/5] t: add test for put_be16()Chandra Pratap, May 29, 2024
  15. [GSoC][PATCH v3 5/5] t: improve the test-case for parse_names()Chandra Pratap, May 29, 2024
  16. Patrick SteinhardtMay 30, 2024
  17. Christian CouderMay 30, 2024
  18. Junio C HamanoMay 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.