git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][PATCH v3 4/5] t: add test for put_be16()

From
CPChandra Pratap <chandrapratap3519@gmail.com>
Date
May 29, 2024, 16:59 UTC
Message-ID
<20240529171439.18271-5-chandrapratap3519@gmail.com>
In-Reply-To
<20240529171439.18271-1-chandrapratap3519@gmail.com>

put_be16() is a function defined in reftable/basics.{c, h} for which there are no tests in the current setup. Add a test for the same.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
 t/unit-tests/t-reftable-basics.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/t/unit-tests/t-reftable-basics.c b/t/unit-tests/t-reftable-basics.c
index b02ca02040..3c08218257 100644
--- a/t/unit-tests/t-reftable-basics.c
+++ b/t/unit-tests/t-reftable-basics.c
@@ -133,6 +133,16 @@ static void test_u24_roundtrip(void)
 	check_int(in, ==, out);
 }
 
+static void test_u16_roundtrip(void)
+{
+	uint32_t in = 0xfef1;
+	uint8_t dest[3];
+	uint32_t out;
+	put_be16(dest, in);
+	out = get_be16(dest);
+	check_int(in, ==, out);
+}
+
 int cmd_main(int argc, const char *argv[])
 {
 	TEST(test_common_prefix(), "common_prefix_size works");
@@ -142,6 +152,7 @@ int cmd_main(int argc, const char *argv[])
 	TEST(test_names_length(), "names_length retuns size of a NULL-terminated string array");
 	TEST(test_names_equal(), "names_equal compares NULL-terminated string arrays");
 	TEST(test_u24_roundtrip(), "put_be24 and get_be24 work");
+	TEST(test_u16_roundtrip(), "put_be16 and get_be16 work");
 
 	return test_done();
 }
-- 
2.45.GIT
Previous: Chandra PratapNext: Chandra Pratap
Message 14 of 18 in “t: port reftable/basics_test.c to the unit testing”
  1. Chandra PratapMay 29, 2024
  2. [GSoC][PATCH v2 1/4] t: move reftable/basics_test.c to the unit testing frameworkChandra Pratap, May 29, 2024
  3. [GSoC][PATCH v2 2/4] t: move tests from reftable/stack_test.c to the new unit testChandra Pratap, May 29, 2024
  4. [GSoC][PATCH v2 3/4] t: move tests from reftable/record_test.c to the new unit testChandra Pratap, May 29, 2024
  5. Patrick SteinhardtMay 29, 2024
  6. Junio C HamanoMay 29, 2024
  7. [GSoC][PATCH v2 4/4] t: add test for put_be16() and improve test-case for parse_names()Chandra Pratap, May 29, 2024
  8. Patrick SteinhardtMay 29, 2024
  9. Patrick SteinhardtMay 29, 2024
  10. [GSoC][PATCH v3 0/4] t: port reftable/basics_test.c to the unit testingChandra Pratap, May 29, 2024
  11. [GSoC][PATCH v3 1/5] t: move reftable/basics_test.c to the unit testing frameworkChandra Pratap, May 29, 2024
  12. [GSoC][PATCH v3 2/5] t: move tests from reftable/stack_test.c to the new unit testChandra Pratap, May 29, 2024
  13. [GSoC][PATCH v3 3/5] t: move tests from reftable/record_test.c to the new unit testChandra Pratap, May 29, 2024
  14. [GSoC][PATCH v3 4/5] t: add test for put_be16()Chandra Pratap, May 29, 2024
  15. [GSoC][PATCH v3 5/5] t: improve the test-case for parse_names()Chandra Pratap, May 29, 2024
  16. Patrick SteinhardtMay 30, 2024
  17. Christian CouderMay 30, 2024
  18. Junio C HamanoMay 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.