[GSoC][PATCH v3 5/5] t: improve the test-case for parse_names()
- From
- Chandra Pratap <chandrapratap3519@gmail.com>
- Date
- May 29, 2024, 16:59 UTC
- Message-ID
- <20240529171439.18271-6-chandrapratap3519@gmail.com>
- In-Reply-To
- <20240529171439.18271-1-chandrapratap3519@gmail.com>
In the existing test-case for parse_names(), the fact that empty lines should be ignored is not obvious because the empty line is immediately followed by end-of-string. This can be mistaken as the empty line getting replaced by NULL. Improve this by adding a non-empty line after the empty one to demonstrate the intended behavior.
Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> --- t/unit-tests/t-reftable-basics.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/unit-tests/t-reftable-basics.c b/t/unit-tests/t-reftable-basics.c index 3c08218257..529049af12 100644 --- a/t/unit-tests/t-reftable-basics.c +++ b/t/unit-tests/t-reftable-basics.c @@ -89,11 +89,13 @@ static void test_parse_names_normal(void) static void test_parse_names_drop_empty(void) { - char in[] = "a\n\n"; + char in[] = "a\n\nb\n"; char **out = NULL; parse_names(in, strlen(in), &out); check_str(out[0], "a"); - check(!out[1]); + /* simply '\n' should be dropped as empty string */ + check_str(out[1], "b"); + check(!out[2]); free_names(out); }
-- 2.45.GIT