Re: [RFC/PATCH v11 10/13] bisect--helper: `check_and_set_terms` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2016, 18:53 UTC
Message-ID: <xmqqa8gvdmtx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <0102015640423cfd-dbacb682-b6fe-4417-a3f2-2c2c6673263c-000000@eu-west-1.amazonses.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

Show 8 quoted lines

> Reimplement the `check_and_set_terms` shell function in C and add
> `check-and-set-terms` subcommand to `git bisect--helper` to call it from
> git-bisect.sh
>
> Using `--check-and-set-terms` subcommand is a temporary measure to port
> shell function in C so as to use the existing test suite. As more
> functions are ported, this subcommand will be retired and will be called
> by some other methods.

I think "this subcommand will be retired but its implementation will be called by ..." would clarify the direction.

Show 5 quoted lines

> +	if (!no_term_file &&
> +	    strcmp(cmd, terms->term_bad.buf) &&
> +	    strcmp(cmd, terms->term_good.buf))
> +		return error(_("Invalid command: you're currently in a "
> +				"'%s' '%s' bisect"), terms->term_bad.buf,

This changes a message text, switching from "... good/bad bisect." to "... 'good' 'bad' bisect". Intended?