Re: [RFC/PATCH v11 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Aug 3, 2016, 20:33 UTC
Message-ID: <CAFZEwPMK5-WXVNts1r=wxZdDVJTTCf6tauSHdWDjRbijqFJ6pg@mail.gmail.com>
In-Reply-To: <xmqq1t27dlhr.fsf@gitster.mtv.corp.google.com>

Hey Junio,

On Wed, Aug 3, 2016 at 12:52 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Pranit Bauva <pranit.bauva@gmail.com> writes:
>
>> +static int bisect_terms(struct bisect_terms *terms, int term_defined)
>> +{
>> +     if (get_terms(terms)) {
>> +             fprintf(stderr, "no terms defined\n");
>> +             return -1;
>> +     }
>> +     if (!term_defined) {
>> +             printf("Your current terms are %s for the old state\nand "
>> +                    "%s for the new state.\n", terms->term_good.buf,
>> +                    terms->term_bad.buf);
>> +             return 0;
>> +     }
>
> In the original, all of the above messages go through gettext; this
> rewrite should do the same.

Sure!

Regards, Pranit Bauva