Re: [RFC/PATCH v11 10/13] bisect--helper: `check_and_set_terms` shell function in C
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Aug 3, 2016, 20:29 UTC
- Message-ID
- <CAFZEwPOERUocOiRvWR6fj1KZm7wcVrp41FVFbhWpdZBMAabUpA@mail.gmail.com>
- In-Reply-To
- <xmqqa8gvdmtx.fsf@gitster.mtv.corp.google.com>
Hey Junio,
On Wed, Aug 3, 2016 at 12:23 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Pranit Bauva <pranit.bauva@gmail.com> writes: > >> Reimplement the `check_and_set_terms` shell function in C and add >> `check-and-set-terms` subcommand to `git bisect--helper` to call it from >> git-bisect.sh >> >> Using `--check-and-set-terms` subcommand is a temporary measure to port >> shell function in C so as to use the existing test suite. As more >> functions are ported, this subcommand will be retired and will be called >> by some other methods. > > I think "this subcommand will be retired but its implementation will > be called by ..." would clarify the direction.
Sure. That seems better.
Show 8 quoted lines
>> + if (!no_term_file &&
>> + strcmp(cmd, terms->term_bad.buf) &&
>> + strcmp(cmd, terms->term_good.buf))
>> + return error(_("Invalid command: you're currently in a "
>> + "'%s' '%s' bisect"), terms->term_bad.buf,
>
> This changes a message text, switching from "... good/bad bisect."
> to "... 'good' 'bad' bisect". Intended?Nope its not intended but its a mistake from my side. Will rectify.
Regards, Pranit Bauva