git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 19, 2017, 02:06 UTC
Message-ID
<xmqqa89jlyrh.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<xmqqinodewdr.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> ...
> So, let's give Pranit a concrete "here is what we want to see
> squashed in", while you guys discuss peculiarity with various
> platforms and their system headers, which admittedly is a more
> interesting tangent ;-)
>
> There are early returns with "goto finish" even before _syn
> variables are first assigned to, so they would need to be
> initialized to NULL.  The other two get their initial values
> right at the beginning, so they are OK.
>
>  builtin/bisect--helper.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)

While we are waiting for the topic to be fixed, I've tentatively applied this on top to update 'pu', so Travis should now be happy with 'pu' on Mac, too.

Previous: Pranit Bauva
Message 8 of 8 in “fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C”
  1. fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in CJohannes Schindelin, Feb 10, 2017
  2. Pranit BauvaFeb 10, 2017
  3. René ScharfeFeb 10, 2017
  4. Johannes SchindelinFeb 13, 2017
  5. René ScharfeFeb 13, 2017
  6. Junio C HamanoFeb 13, 2017
  7. Pranit BauvaFeb 13, 2017
  8. Junio C HamanoFeb 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.