Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Feb 10, 2017, 15:30 UTC
- Message-ID
- <CAFZEwPOo6RPKgf-FKL6GNPK2RDtw00=WvaBYMjeoZXX+wHkjwA@mail.gmail.com>
- In-Reply-To
- <a1b9143bb29a8a5979dd733ed20161e6769b2b83.1486736391.git.johannes.schindelin@gmx.de>
Hey Johannes,
On Fri, Feb 10, 2017 at 7:50 PM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
Show 19 quoted lines
> > It is curious that only MacOSX builds trigger an error about this, both > GCC and Clang, but not Linux GCC nor Clang (see > https://travis-ci.org/git/git/jobs/200182819#L1152 for details): > > builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used > uninitialized whenever 'if' condition is true > [-Werror,-Wsometimes-uninitialized] > if (missing_good && !missing_bad && current_term && > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > builtin/bisect--helper.c:350:7: note: uninitialized use occurs here > if (!good_syn) > ^~~~~~~~ > > If you "re-roll" (or, as pointed out at the Contributors' Summit, better > put: if you send another iteration of the patch series), please squash > this fix in. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Thanks for making this fix! :) I will squash it in.
Regards, Pranit Bauva